SAMM-CLI aas generation: Mapping of Set Characteristics #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yauhenikapl
changed the title
...odel-aas-generator/src/main/java/org/eclipse/esmf/aspectmodel/aas/AspectModelAasVisitor.java
Outdated
Show resolved
Hide resolved
BirgitBoss
requested changes
Jul 10, 2024
atextor
requested changes
Aug 21, 2024
...odel-aas-generator/src/main/java/org/eclipse/esmf/aspectmodel/aas/AspectModelAasVisitor.java
Show resolved
Hide resolved
| * @return the transformed string in the format "_role[8_characters_of_hash]" | ||
| * @throws NoSuchAlgorithmException if the SHA-256 algorithm is not available | ||
| */ | ||
| private String transformEnumerationValue( final String enumValue ) throws NoSuchAlgorithmException { |
There was a problem hiding this comment.
How would the mapping work in the opposite direction with this approach?
There was a problem hiding this comment.
I think, that I have to add separate method in the opposite direction.
Thanks!
BirgitBoss
approved these changes
Sep 11, 2024
| defaultProperty.setIdShort( context.getPropertyShortId() ); | ||
| defaultProperty.setValueType( AasDataTypeMapper.mapAspectTypeToAasXsdDataType( mapType( type ) ) ); | ||
| defaultProperty.setDisplayName( LangStringMapper.NAME.map( property.getPreferredNames() ) ); | ||
| defaultProperty.setSemanticId( buildPropertyReferenceToGlobalReference( property ) ); |
There was a problem hiding this comment.
Could you please explain more, because in this method "buildPropertyReferenceToGlobalReference" we building GlobalReference, not property reference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
Fixes #481
Type of change
Checklist: