Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[content assist] Duplicate constructor completion #195

Closed
snjeza opened this issue Jul 6, 2022 · 2 comments · Fixed by #196
Closed

[content assist] Duplicate constructor completion #195

snjeza opened this issue Jul 6, 2022 · 2 comments · Fixed by #196
Labels
bug Something isn't working regression Something was broken by a previous change
Milestone
4.25 M2

Comments

@snjeza
Copy link
Contributor

snjeza commented Jul 6, 2022 •
edited
Loading

Version: ba0944d

Steps to reproduce:
constructor

A related issue -eclipse-jdtls/eclipse.jdt.ls#2147
@snjeza snjeza mentioned this issue Jul 6, 2022
Merged
@rgrunber
Copy link
Contributor

rgrunber commented Jul 7, 2022 •
edited
Loading

Just saw this as well while trying the PR referenced.

Update : Reproduced with
Version: 2022-06 (4.25)
Build id: I20220706-1800

It worked on 2021-09 (4.21) and broke on 2021-12 (4.22)

@rgrunber rgrunber mentioned this issue Jul 9, 2022
Merged
@rgrunber rgrunber added the bug Something isn't working label Jul 9, 2022
@rgrunber
Copy link
Contributor

I think this was introduced by https://bugs.eclipse.org/bugs/show_bug.cgi?id=575631 ( ce59f24#diff-8469e0f05a7f350e7047101a3e20fe0bf4d0f65df01fa0a18eb6378128c5de5aR3795 ) . The time-frame matches up.

@rgrunber rgrunber added the regression Something was broken by a previous change label Jul 11, 2022
@rgrunber rgrunber added this to the 4.25 M2 milestone Jul 12, 2022
@snjeza snjeza mentioned this issue Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working regression Something was broken by a previous change
Projects
None yet
Milestone
4.25 M2
Development

Successfully merging a pull request may close this issue.

Prevent duplicate constructor completion proposals snjeza/eclipse.jdt.core
2 participants
@snjeza @rgrunber