Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aggregator build as github validation step #1917

Open
iloveeclipse opened this issue Jan 26, 2024 · 3 comments · May be fixed by #2194
Open

Add aggregator build as github validation step #1917

iloveeclipse opened this issue Jan 26, 2024 · 3 comments · May be fixed by #2194
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@iloveeclipse
Copy link
Member

iloveeclipse commented Jan 26, 2024 •
edited
Loading

See comment from @laeubi on eclipse-platform/eclipse.platform.releng.aggregator#1750 (comment)

Tycho uses a (quick) build of the aggregator to catch > issues early, maybe JDT can use similar to be aware of such unanticipated changes when compiler is fixed, but its just an idea, total > runtime is about 17 minutes.

The idea is: new github action could be added to JDT PR validation workflow at github. The action would run SDK aggregator build with latest ecj state from PR. This would allow contributors see if the change in compiler "breaks" SDK build before actual nightly SDK build fails.

Contributions are welcome.
@iloveeclipse iloveeclipse added enhancement New feature or request help wanted Extra attention is needed labels Jan 26, 2024
@iloveeclipse iloveeclipse mentioned this issue Jan 26, 2024
Closed
laeubi added a commit to laeubi/eclipse.jdt.core that referenced this issue Jan 28, 2024
@laeubi
Add a validation step that check if a possible baseline problem is found
28b5f1c 
Fix eclipse-jdt#1917
@laeubi
Copy link
Contributor

laeubi commented Jan 28, 2024

I have now started some tests here:

@laeubi
Copy link
Contributor

laeubi commented Jan 28, 2024

@iloveeclipse can you suggest a change that will generate a compare error so I can check the action works?

@iloveeclipse
Copy link
Member Author

iloveeclipse commented Jan 28, 2024 •
edited
Loading

can you suggest a change that will generate a compare error so I can check the action works?

Revert #1906, it should cause 3 comparator errors in platform

laeubi added a commit to laeubi/eclipse.jdt.core that referenced this issue Mar 5, 2024
@laeubi
Add a validation step that check if a possible baseline problem is found
1ba73bb 
Fix eclipse-jdt#1917
laeubi added a commit to laeubi/eclipse.jdt.core that referenced this issue Mar 21, 2024
@laeubi
Add a validation step that check if a possible baseline problem is found
73affd1 
Fix eclipse-jdt#1917
laeubi added a commit to laeubi/eclipse.jdt.core that referenced this issue Mar 21, 2024
@laeubi
Add a validation step that check if a possible baseline problem is found
1f2a33e 
Fix eclipse-jdt#1917
@laeubi laeubi linked a pull request Mar 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a validation step that check if a possible baseline problem is found laeubi/eclipse.jdt.core
2 participants
@iloveeclipse @laeubi