Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Pull Up Refactoring] Pull up refactoring for the method in Nested Anonymous Class produce uncompilable code #1772

Open
RETester66 opened this issue Nov 6, 2024 · 0 comments

Comments

@RETester66
Copy link

Steps to reproduce

The input program is following:

public class A {
    public class BaseTargetClass {}

    public class OriginalClass {
        public int data = 40;
        public void memberMethod() {
            System.out.println("Nested anonymous data: " + data);
        }

        public class NestedOriginalClass extends BaseTargetClass {
            void setup() {
                new BaseTargetClass() {
                    void methodToBePulledUp() {
                        new BaseTargetClass() {
                            void innerMethod() {
                                System.out.println("Deeply nested method: " + data);
                            }
                        };
                    }
                };
            }
        }
    }
}

Left click the methodToBePulledUp(), then right click -> Refactor -> Pull Up, and use the default configurations (the destination is set as BaseTargetClass by default) as following, click Finish:

image

The refactoring is performed without any warning or exception. The refactored program is following, which contains syntax error:

public class A {
    public class BaseTargetClass {

		void methodToBePulledUp() {
		    new BaseTargetClass() {
		        void innerMethod() {
		            System.out.println("Deeply nested method: " + data);// syntax error
		        }
		    };
		}}

    public class OriginalClass {
        public int data = 40;
        public void memberMethod() {
            System.out.println("Nested anonymous data: " + data);
        }

        public class NestedOriginalClass extends BaseTargetClass {
            void setup() {
                new BaseTargetClass() {
                };
            }
        }
    }
}

Environment

OS Version

Windows 10, 64-bit Operating System, x64-based processor

Eclipse Version

Eclipse IDE for Enterprise Java and Web Developers (includes Incubating components)
Version: 2024-09 (4.33.0)
Build id: 20240905-0614

JDK Version

java version "22.0.1" 2024-04-16
Java(TM) SE Runtime Environment (build 22.0.1+8-16)
Java HotSpot(TM) 64-Bit Server VM (build 22.0.1+8-16, mixed mode, sharing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant