Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard decorator instead of annotation token type for highlighting Java annotation #3210

Open
angelozerr opened this issue Jul 5, 2024 · 3 comments

Comments

@angelozerr
Copy link

When annotation is used in Java class,

@Deprecated
public class Foo {

}

the JDT LS semantic tokens should use decorator instead of annotation as token type, because annotation is not a standard token type, although decorator belongs to LSP specification.

@angelozerr angelozerr changed the title Use decorator instead of annotation token type for highlighting Java annotation Use standard decorator instead of annotation token type for highlighting Java annotation Jul 5, 2024
@0dinD
Copy link
Contributor

0dinD commented Sep 3, 2024

I agree. The reason why annotation is used right now is that decorator was added in LSP 3.17 and so didn't exist in 3.16 when the LSP-based semantic highlighting implementation was created.

@angelozerr
Copy link
Author

Thanks @0dinD for your answer.

I understand but now this decorator exists it would be nice to use it.

@0dinD
Copy link
Contributor

0dinD commented Sep 4, 2024

Yeah, again, I agree 🙂

I was just explaining why JDT LS came to use annotation instead of decorator. Either way I'll probably send a PR to fix this at some point in the not-so-distant future if no one else does, but I can't prioritize it right now as I'm a bit busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants