CryptoTests cryptotest/tests/SignatureTests.java timeout in java.math.BigInteger.implSquareToLen #16711

pshipton · 2023-02-13T14:45:05Z

https://openj9-jenkins.osuosl.org/job/Test_openjdk17_j9_extended.functional_x86-64_linux_Nightly_testList_0/394/ - ub16x64j96
CryptoTests_0
cryptotest/tests/SignatureTests.java

timeout, no diagnostic files.

133)	SunEC: 	SHA1withECDSA~SHA1withECDSA	 (Signature)

"MainThread" prio=5 Id=22 RUNNABLE
	at [email protected]/java.math.BigInteger.implSquareToLen(BigInteger.java:2212)
	at [email protected]/java.math.BigInteger.squareToLen(BigInteger.java:2124)
	at [email protected]/java.math.BigInteger.implMontgomerySquare(BigInteger.java:2866)
	at [email protected]/java.math.BigInteger.montgomerySquare(BigInteger.java:2823)
	at [email protected]/java.math.BigInteger.oddModPow(BigInteger.java:3093)
	at [email protected]/java.math.BigInteger.modPow(BigInteger.java:2754)
	at [email protected]/java.math.BigInteger.passesMillerRabin(BigInteger.java:1122)
	at [email protected]/java.math.BigInteger.primeToCertainty(BigInteger.java:978)
	at [email protected]/java.math.BitSieve.retrieve(BitSieve.java:203)
	at [email protected]/java.math.BigInteger.largePrime(BigInteger.java:847)
	at [email protected]/java.math.BigInteger.probablePrime(BigInteger.java:785)
	at [email protected]/sun.security.rsa.RSAKeyPairGenerator.generateKeyPair(RSAKeyPairGenerator.java:173)
	at [email protected]/java.security.KeyPairGenerator$Delegate.generateKeyPair(KeyPairGenerator.java:727)
	at [email protected]/java.security.KeyPairGenerator.genKeyPair(KeyPairGenerator.java:495)
	at app//cryptotest.utils.KeysNaiveGenerator.getRsaKeyPair(KeysNaiveGenerator.java:165)
	at app//cryptotest.utils.KeysNaiveGenerator.getRsaPrivateKey(KeysNaiveGenerator.java:169)
	at app//cryptotest.tests.SignatureTests.checkAlgorithm(SignatureTests.java:85)
	at app//cryptotest.utils.AlgorithmTest.mainLoop(AlgorithmTest.java:79)
	at app//cryptotest.tests.SignatureTests.main(SignatureTests.java:68)

The text was updated successfully, but these errors were encountered:

pshipton · 2023-02-13T14:49:46Z

https://openj9-jenkins.osuosl.org/job/Test_openjdk17_j9_extended.functional_s390x_linux_Nightly_testList_1/415 - ub20-390-3
CryptoTests_0
cryptotest/tests/SignatureTests.java

72)	SunRsaSign: 	SHA384withRSA~OID.1.2.840.113549.1.1.12	 (Signature)

"MainThread" prio=5 Id=22 RUNNABLE
	at [email protected]/java.math.BigInteger.implSquareToLen(BigInteger.java:2202)
	at [email protected]/java.math.BigInteger.squareToLen(BigInteger.java:2124)
	at [email protected]/java.math.BigInteger.square(BigInteger.java:2093)
	at [email protected]/java.math.BigInteger.square(BigInteger.java:2076)
	at [email protected]/java.math.BigInteger.lucasLehmerSequence(BigInteger.java:1070)
	at [email protected]/java.math.BigInteger.passesLucasLehmer(BigInteger.java:998)
	at [email protected]/java.math.BigInteger.primeToCertainty(BigInteger.java:978)
	at [email protected]/java.math.BitSieve.retrieve(BitSieve.java:203)
	at [email protected]/java.math.BigInteger.largePrime(BigInteger.java:847)
	at [email protected]/java.math.BigInteger.probablePrime(BigInteger.java:785)
	at [email protected]/sun.security.rsa.RSAKeyPairGenerator.generateKeyPair(RSAKeyPairGenerator.java:187)
	at [email protected]/java.security.KeyPairGenerator$Delegate.generateKeyPair(KeyPairGenerator.java:721)
	at [email protected]/java.security.KeyPairGenerator.genKeyPair(KeyPairGenerator.java:495)
	at app//cryptotest.utils.KeysNaiveGenerator.getRsaKeyPair(KeysNaiveGenerator.java:165)
	at app//cryptotest.utils.KeysNaiveGenerator.getRsaPrivateKey(KeysNaiveGenerator.java:169)
	at app//cryptotest.tests.SignatureTests.checkAlgorithm(SignatureTests.java:85)
	at app//cryptotest.utils.AlgorithmTest.mainLoop(AlgorithmTest.java:79)
	at app//cryptotest.tests.SignatureTests.main(SignatureTests.java:68)

pshipton · 2023-02-13T14:56:49Z

@0xdaryl it seems OpenJ9 is too slow to complete this newly added test. I notice jdk17 implSquareToLen() has an @IntrinsicCandidate annotation, while in jdk11 it's @HotSpotIntrinsicCandidate.

@llxia can we increase the timeout setting for this test?
timeout set to 120000ms

pshipton · 2023-02-13T15:07:24Z

https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_extended.functional_aarch64_linux_Nightly_testList_0/99 - cent8-aarch64-1
CryptoTests_0
cryptotest/tests/SignatureTests.java

34)	SUN: 	SHA3-256withDSA~OID.2.16.840.1.101.3.4.3.6	 (Signature)

"MainThread" prio=5 Id=27 RUNNABLE
	at [email protected]/java.math.BigInteger.implMulAdd(BigInteger.java:3320)

https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_extended.functional_aarch64_mac_Nightly_testList_0/103

90)	SunRsaSign: 	SHA512withRSA~OID.1.2.840.113549.1.1.13	 (Signature)

https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_extended.functional_ppc64_aix_Nightly_testList_1/100

40)	SUN: 	SHA256withDSA~OID.2.16.840.1.101.3.4.3.2	 (Signature)

"MainThread" prio=5 Id=35 RUNNABLE
	at [email protected]/java.math.BigInteger.implSquareToLen(BigInteger.java:2316)

https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_extended.functional_ppc64le_linux_Nightly_testList_1/101

46)	SUN: 	NONEwithDSA~RawDSA	 (Signature)

"MainThread" prio=5 Id=35 RUNNABLE
	at [email protected]/java.math.BigInteger.implMulAddCheck(BigInteger.java:3296)

https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_extended.functional_s390x_linux_Nightly_testList_1/102

29)	SUN: 	SHA512withDSA~2.16.840.1.101.3.4.3.4	 (Signature)

"MainThread" prio=5 Id=23 RUNNABLE
	at [email protected]/java.math.BigInteger.montReduce(BigInteger.java:3241)

https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_extended.functional_x86-64_linux_Nightly_testList_1/100

25)	SUN: 	SHA3-512withDSA~OID.2.16.840.1.101.3.4.3.8	 (Signature)

"MainThread" prio=5 Id=23 RUNNABLE
	at [email protected]/java.math.BigInteger.implSquareToLen(BigInteger.java:2316)

https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_extended.functional_x86-64_mac_Nightly_testList_0/99

91)	SunRsaSign: 	SHA512withRSA~1.2.840.113549.1.1.13	 (Signature)

pshipton · 2023-02-13T15:16:06Z

cryptotest/CryptoTest.java is also timing out
https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_extended.functional_ppc64_aix_Nightly_testList_1/100
https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_extended.functional_ppc64le_linux_Nightly_testList_1/101
https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_extended.functional_s390x_linux_Nightly_testList_1/102
https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_extended.functional_x86-64_linux_Nightly_testList_1/100

pshipton · 2023-02-13T15:23:50Z

and cryptotest/tests/SecureRandomTests.java
https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_extended.functional_x86-64_linux_Nightly_testList_1/100

pshipton · 2023-02-13T15:34:56Z

The jdk19 timeouts are also happening on Adoptium builds.

llxia · 2023-02-13T21:54:42Z

I can set -timeoutFactor:2 (instead of 1). But I am not sure if it is the best way to do it.
https://openj9-jenkins.osuosl.org/job/Grinder/2022/

llxia · 2023-02-14T19:49:35Z

Increase timeout for CryptoTests: adoptium/aqa-tests#4339

0xdaryl · 2023-03-14T12:30:59Z

I notice jdk17 implSquareToLen() has an @IntrinsicCandidate annotation, while in jdk11 it's @HotSpotIntrinsicCandidate.

Interesting. I believe our intrinsics matching code is only looking for the former, not the latter. But it is the former that might be the issue in this case. We'll investigate the slowness, but not for 0.38.

0xdaryl · 2023-03-14T12:33:54Z

@BradleyWood : please investigate the slowdown here. I moved this to 0.40.

BradleyWood · 2023-07-12T14:44:16Z

@0xdaryl it seems OpenJ9 is too slow to complete this newly added test. I notice jdk17 implSquareToLen() has an @IntrinsicCandidate annotation, while in jdk11 it's @HotSpotIntrinsicCandidate.

I don't think implSquareToLen intrinsic was ever implemented in OpenJ9 on any platform. I think we should open an issue to implement it, and any other unimplemented intrinsics.

hzongaro · 2023-08-14T21:30:50Z

Reassigning to @jmesyou, as he's working on issue #17778.

I'm not sure whether we need both issues, or if #17778 will act as an epic issue with this as a subtask. I'll leave it for him to decide.

hzongaro · 2023-08-22T15:01:00Z

I'm assuming this won't be ready for the 0.41 code split, so I'll move it out to 0.43.

pshipton added test failure triageRequired labels Feb 13, 2023

pshipton added comp:jit comp:test labels Feb 13, 2023

pshipton added this to the Release 0.38 (Java 8, 11, 17) Apr refresh milestone Feb 13, 2023

pshipton mentioned this issue Feb 13, 2023

JITServer crypto failures on ppc64le #16715

Open

llxia mentioned this issue Feb 15, 2023

Increase timeout for CryptoTests adoptium/aqa-tests#4339

Merged

0xdaryl modified the milestones: Release 0.38 (Java 8, 11, 17) Apr refresh, Release 0.40? (Java 8, 11, 17, 20) July refresh Mar 14, 2023

zzambers mentioned this issue Apr 18, 2023

CryptoTests_0 FAILED in x86-32_windows, x86-64_windows, arm_linux and solaris platforms adoptium/aqa-tests#4336

Open

0xdaryl assigned BradleyWood May 29, 2023

0xdaryl modified the milestones: Release 0.40 (Java 8, 11, 17, 20) July refresh, Release 0.41 (Java 8, 11, 17) Oct refresh Jun 5, 2023

BradleyWood mentioned this issue Jul 12, 2023

Implement various intrinsics in the JIT #17778

Open

hzongaro removed the triageRequired label Aug 14, 2023

hzongaro assigned jmesyou and unassigned BradleyWood Aug 14, 2023

hzongaro modified the milestones: Release 0.41 (Java 8, 11, 17) Oct refresh, Release 0.43 (Java 8, 11, 17, 21) Jan refresh Aug 22, 2023

hzongaro modified the milestones: Release 0.43 (Java 8, 11, 17, 21) Jan refresh, Release 0.44 (Java 8, 11, 17, 21) Apr refresh Oct 30, 2023

hzongaro modified the milestones: Release 0.44 (Java 8, 11, 17, 21) Apr refresh, Release 0.45 (Java 8, 11, 17, 21, 22) July refresh Jan 30, 2024

cjjdespres mentioned this issue Feb 12, 2024

Modify ROMclass packing to normalize more #18848

Merged

hzongaro unassigned jmesyou May 15, 2024

hzongaro modified the milestones: Release 0.46 (Java 8, 11, 17, 21, 22) July refresh, Future May 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CryptoTests cryptotest/tests/SignatureTests.java timeout in java.math.BigInteger.implSquareToLen #16711

CryptoTests cryptotest/tests/SignatureTests.java timeout in java.math.BigInteger.implSquareToLen #16711

pshipton commented Feb 13, 2023 •

edited

Loading

pshipton commented Feb 13, 2023 •

edited

Loading

pshipton commented Feb 13, 2023

pshipton commented Feb 13, 2023 •

edited

Loading

pshipton commented Feb 13, 2023 •

edited

Loading

pshipton commented Feb 13, 2023

pshipton commented Feb 13, 2023

llxia commented Feb 13, 2023

llxia commented Feb 14, 2023

0xdaryl commented Mar 14, 2023 •

edited

Loading

0xdaryl commented Mar 14, 2023

BradleyWood commented Jul 12, 2023

hzongaro commented Aug 14, 2023

hzongaro commented Aug 22, 2023

CryptoTests cryptotest/tests/SignatureTests.java timeout in java.math.BigInteger.implSquareToLen #16711

CryptoTests cryptotest/tests/SignatureTests.java timeout in java.math.BigInteger.implSquareToLen #16711

Comments

pshipton commented Feb 13, 2023 • edited Loading

pshipton commented Feb 13, 2023 • edited Loading

pshipton commented Feb 13, 2023

pshipton commented Feb 13, 2023 • edited Loading

pshipton commented Feb 13, 2023 • edited Loading

pshipton commented Feb 13, 2023

pshipton commented Feb 13, 2023

llxia commented Feb 13, 2023

llxia commented Feb 14, 2023

0xdaryl commented Mar 14, 2023 • edited Loading

0xdaryl commented Mar 14, 2023

BradleyWood commented Jul 12, 2023

hzongaro commented Aug 14, 2023

hzongaro commented Aug 22, 2023

pshipton commented Feb 13, 2023 •

edited

Loading

pshipton commented Feb 13, 2023 •

edited

Loading

pshipton commented Feb 13, 2023 •

edited

Loading

pshipton commented Feb 13, 2023 •

edited

Loading

0xdaryl commented Mar 14, 2023 •

edited

Loading