Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize compiler threads pre-checkpoint and post-restore #16859

Open
3 of 4 tasks
dsouzai opened this issue Mar 8, 2023 · 0 comments
Open
3 of 4 tasks

Synchronize compiler threads pre-checkpoint and post-restore #16859

dsouzai opened this issue Mar 8, 2023 · 0 comments
Labels
comp:jit criu Used to track CRIU snapshot related work

Comments

@dsouzai
Copy link
Contributor

dsouzai commented Mar 8, 2023

Compilation Threads are already synchronized across a checkpoint/restore (#14331). However, other threads such as the Sampler and IProfiler are not. These threads may access certain structures that may need to be updated post restore. Therefore, all compiler threads should be synchronized to prevent any races with with pre-checkpoint/post-restore compensation. The synchronization should ideally be architected in such a way that any other such service threads created in the future are also either handled by the infrastructure, or inform the developer to add the logic to handle it for CRIU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit criu Used to track CRIU snapshot related work
Projects
None yet
Development

No branches or pull requests

1 participant