Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valhalla disables JDK22+ Jep454Tests temporarily #18583

Closed
JasonFengJ9 opened this issue Dec 8, 2023 · 1 comment · Fixed by #20332
Closed

Valhalla disables JDK22+ Jep454Tests temporarily #18583

JasonFengJ9 opened this issue Dec 8, 2023 · 1 comment · Fixed by #20332
Labels
project:valhalla Used to track Project Valhalla related work test excluded

Comments

@JasonFengJ9
Copy link
Member

JasonFengJ9 commented Dec 8, 2023

Current valhalla is at jdk-22+15 which is well behind OpenJDK head jdk-23+1.

This gap caused the merging conflicts for openj9-openjdk-jdk.valuetypes, preventing merging with recent OpenJDK updates, and causing valhalla PR test failures:
https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_x86-64_linux_vt_standard_Personal_testList_1/44/console

15:23:00      [javac] /home/jenkins/workspace/Test_openjdknext_j9_sanity.functional_x86-64_linux_vt_standard_Personal_testList_1/aqa-tests/functional/Java22andUp/src/org/openj9/test/jep454/upcall/InvalidUpCallTests.java:308: error: method critical in interface Option cannot be applied to given types;
15:23:00      [javac] 		MethodHandle mh = linker.downcallHandle(functionSymbol, fd, Linker.Option.critical(false));
15:23:00      [javac] 		                                                                         ^
15:23:00      [javac]   required: no arguments
15:23:00      [javac]   found:    boolean
15:23:00      [javac]   reason: actual and formal argument lists differ in length
15:23:01      [javac] 4 errors
15:23:02  
15:23:02  BUILD FAILED

Resolving the merging conflict and porting OpenJDK jdk-23+1 changes to Valhalla extension repo requires large changes and seems risky.
Proposing Valhalla disables JDK22+ Jep454Tests temporarily until the Valhalla project is updated with a recent OpenJDK tag.

Copy link

Issue Number: 18583
Status: Closed
Actual Components: project:valhalla, test excluded
Actual Assignees: No one :(
PR Assignees: JasonFengJ9, theresa-m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project:valhalla Used to track Project Valhalla related work test excluded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant