Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safeguard for subscribing to empty list of topics. #690

Closed
peromvikgoodtech opened this issue Nov 29, 2022 · 1 comment
Closed

Safeguard for subscribing to empty list of topics. #690

peromvikgoodtech opened this issue Nov 29, 2022 · 1 comment
Labels
Status: Completed Nothing further to be done with this issue, it can be closed by the requestor or committer. Type: Bug

Comments

@peromvikgoodtech
Copy link

I had an issue where I mistakenly called MqttClient.subscribe() with an empty list inside the on_connect() callback, as recommended in the docs. Instead of raising an error, the client disconnects and enters an indefinite reconnect loop.

Recommended fix: Assert non-emptiness of list passed to the subscribe method in MqttClient.
@github-actions github-actions bot added the Status: Available No one has claimed responsibility for resolving this issue. label Nov 29, 2022
@ralight ralight added the Status: Completed Nothing further to be done with this issue, it can be closed by the requestor or committer. label Jan 20, 2023
@ralight
Copy link
Contributor

ralight commented Jan 20, 2023

Thank you, I've fixed that.

@ralight ralight added Type: Bug and removed Status: Available No one has claimed responsibility for resolving this issue. labels Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Completed Nothing further to be done with this issue, it can be closed by the requestor or committer. Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralight @peromvikgoodtech