Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are flaky on master #789

Closed
akx opened this issue Jan 3, 2024 · 2 comments
Closed

Tests are flaky on master #789

akx opened this issue Jan 3, 2024 · 2 comments
Labels
Status: Available No one has claimed responsibility for resolving this issue. Type: Enhancement A new feature for a minor or major release.
Milestone
v2.1.0

Comments

@akx
Copy link
Contributor

akx commented Jan 3, 2024

Tests are currently flaky on master. These seem to be the newly re-enabled MQTTv5 tests.

@PierreF Instead of paho.mqtt.testing, would it make sense to just use Mosquitto here?
@github-actions github-actions bot added the Status: Available No one has claimed responsibility for resolving this issue. label Jan 3, 2024
@akx akx mentioned this issue Jan 3, 2024
Merged
@PierreF PierreF mentioned this issue Jan 3, 2024
Merged
@PierreF
Copy link
Contributor

PierreF commented Jan 3, 2024

MQTTv5 test aren't optimal in current form. They are very slow (I've quickly looked and didn't find a way to make them run faster easily).

Yes doing test using a real broker like mosquitto might be a good solution.

@MattBrittan MattBrittan added the Type: Enhancement A new feature for a minor or major release. label Jan 8, 2024
@PierreF PierreF mentioned this issue Mar 24, 2024
Merged
@PierreF PierreF added this to the 2.1.0 milestone Apr 7, 2024
@PierreF PierreF mentioned this issue Apr 29, 2024
Open
7 tasks
@PierreF
Copy link
Contributor

PierreF commented Apr 29, 2024

Done some fix in e96ff75 which seems good enough. The last run on master worker without need to retry.

@PierreF PierreF closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Available No one has claimed responsibility for resolving this issue. Type: Enhancement A new feature for a minor or major release.
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
3 participants
@akx @PierreF @MattBrittan