[win32] fix getting checkbox size from OS #1574
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes fetching the checkbox size for custom drawn checkbox buttons. Instead of using the zoom adjusted by the swt.autoScale setting the native zoom is used. This is neccessary, because the checkbox will be drawn by the OS and therefore is matching the native zoom as well. Fixes eclipse-platform#1573
Test Results 483 files ±0 483 suites ±0 7m 40s ⏱️ - 1m 9s For more details on these failures, see this check. Results for commit 3e04710. ± Comparison against base commit df66a8b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes fetching the checkbox size for custom drawn checkbox buttons. Instead of using the zoom adjusted by the swt.autoScale setting the native zoom is used. This is neccessary, because the checkbox will be drawn by the OS and therefore is matching the native zoom as well.
Fixes #1573