Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CompletionItemKind#User and CompletionItemKind#Issue #10003

Closed
Tracked by #9863
tsmaeder opened this issue Aug 31, 2021 · 2 comments · Fixed by #10123
Closed
Tracked by #9863

Add CompletionItemKind#User and CompletionItemKind#Issue #10003

tsmaeder opened this issue Aug 31, 2021 · 2 comments · Fixed by #10123
Labels
good first issue good first issues for new contributors vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

Feature Description:

Add User and Issue enum values to `CompletionItemKind. If we convert the values correctly, they should be handled by the editor.
@tsmaeder tsmaeder added good first issue good first issues for new contributors vscode issues related to VSCode compatibility labels Aug 31, 2021
@tsmaeder tsmaeder mentioned this issue Aug 31, 2021
Closed
48 tasks
@msujew
Copy link
Member

msujew commented Aug 31, 2021

I think this was already resolved by #9908

@tsmaeder
Copy link
Contributor Author

@msujew thanks for the pointer, but the constants are missing in theia.d.ts, so the comparison matrix is still not green. But the fix becomes trivial, I guess.

@Archie27376 Archie27376 mentioned this issue Sep 16, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue good first issues for new contributors vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CompletionItemKind: add enum values User and Issue Archie27376/theia
2 participants
@msujew @tsmaeder