Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] Support optional property MarkdownString#supportThemeIcons #11129

Closed
Tracked by #9863
planger opened this issue May 11, 2022 · 2 comments · Fixed by #11083
Closed
Tracked by #9863

[vscode] Support optional property MarkdownString#supportThemeIcons #11129

planger opened this issue May 11, 2022 · 2 comments · Fixed by #11083
Labels
vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented May 11, 2022

Feature Description:

Support optionally specifying whether a MarkdownString supports ThemeIcons via the constructor or property supportThemeIcons, see https://code.visualstudio.com/api/references/vscode-api#MarkdownString

See also #11128
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label May 11, 2022
@colin-grant-work
Copy link
Contributor

This should be addressed by #11083, which pulls in VSCode's MarkdownString implementation.

@planger
Copy link
Contributor Author

planger commented May 11, 2022

@colin-grant-work Thanks, that's great! Do you want to add this issue to the list of fixed issues by your PR?
I'm currently working through the 1.55.2 API and create issues for all missing API for which there isn't an issue and add respective notes to the report.

@JonasHelming JonasHelming mentioned this issue May 13, 2022
Closed
48 tasks
@colin-grant-work colin-grant-work mentioned this issue May 13, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement missing API for [email protected] colin-grant-work/theia
3 participants
@planger @vince-fugnitto @colin-grant-work