Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo: update dependencies following 1.68.1 API bump #12080

Closed
vince-fugnitto opened this issue Jan 17, 2023 · 4 comments
Closed

repo: update dependencies following 1.68.1 API bump #12080

vince-fugnitto opened this issue Jan 17, 2023 · 4 comments
Labels
dependencies pull requests that update a dependency file electron issues related to the electron target vscode issues related to VSCode compatibility

Comments

@vince-fugnitto
Copy link
Member

Feature Description:

With the bump of our default API to 1.68.1 we should also think about aligning our dependencies to that version, mainly for electron and node.

We should:

  • bump electron from 15.3.5 to 17.4.7
  • drop support for node 14
  • update any other dependencies as needed

We need to ensure that plugins built for 1.68.1 run in type of environment and conditions present in VS Code.
@vince-fugnitto vince-fugnitto added electron issues related to the electron target vscode issues related to VSCode compatibility dependencies pull requests that update a dependency file labels Jan 17, 2023
@paul-marechal
Copy link
Member

Electron 22 still uses Node 16, let's aim for that? https://www.electronjs.org/blog/electron-22-0

@tsmaeder
Copy link
Contributor

Note that our current electron version is causing problems: #12192 (comment)

@tsmaeder
Copy link
Contributor

tsmaeder commented Mar 2, 2023

I'm planning to update electron as part of #2018

@vince-fugnitto
Copy link
Member Author

I believe the issue can be closed:

  • electron was bumped
  • node 14 was dropped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies pull requests that update a dependency file electron issues related to the electron target vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tsmaeder @paul-marechal @vince-fugnitto