QuickInput is not always picking the first element as a fallback on Enter

[federicobozzini]

Bug Description:

Bug similar to the one described by #11979 .

When changing the text of the quick pick creates a new element, the new element is not automatically selected and pressing ENTER just dismisses the quick pick.

Steps to Reproduce:

As an example, in the Theia web blueprint

1. press F1 and choose clone from URL...
2. add any URL, press enter
3. Nothing happens. The behaviour expected would be the same one of vs-code where the application would try to clone the URL.

The same behaviour happens for operations like creating a new branch, after adding a branch name and pressing ENTER nothing happens.

Additional Information

• Operating System: 20.04
• Theia Version: Theia web Blueprint at 06/04/2023

[vince-fugnitto]

@federicobozzini what version is "theia web blueprint" using, from what I can tell it is 1.33.0 which does not have the fix. If you try master of this repo it works well.

[federicobozzini]

This is the behaviour I see with version 1.36, when clicking Enter:

Nothing happens.

If instead I click on the quick pick entry with my mouse the item is correctly selected and Theia gets cloned.

[vince-fugnitto]

@federicobozzini I believe that the git: clone... command present in @theia/git (which is not present in theia-blueprint as it uses the builtins) is likely the only use-case that has the behavior as we handle quick-input differently than other use-cases. A specific fix is likely needed for this use-case if you're interested.

[federicobozzini]

@vince-fugnitto Are you saying that only the clone behaviour should currently be different or also other commands in the @theia/git? Just as a reference I see the same behaviour for the command to switch the current git branch, with the quickinput to create a new branch.

[vince-fugnitto]

I suspect other @theia/git commands might have similar issues as they include some custom logic, or handling of quick-inputs. For standard quick-input (basic use-cases, plugins) the behavior is fine where it properly sets the first item as selected.