Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file search does not highlight properly #4548

Open
akosyakov opened this issue Mar 13, 2019 · 2 comments
Open

file search does not highlight properly #4548

akosyakov opened this issue Mar 13, 2019 · 2 comments
Labels
bug bugs found in the application file search issues related to the file search

Comments

@akosyakov
Copy link
Member

Results are correct, but highlighting not.
Screen Shot 2019-03-13 at 10 37 39

The root cause that we rely on Monaco fuzzy match to highlight label and description part and it cannot. Instead of we should compute highlights ourself on backend and split it for label and backend on frontend.
@akosyakov akosyakov added bug bugs found in the application file search issues related to the file search labels Mar 13, 2019
@akosyakov
Copy link
Member Author

It's a follow-up of #4549

@vince-fugnitto vince-fugnitto mentioned this issue Jul 9, 2019
Closed
@akosyakov
Copy link
Member Author

See also #5638 (comment)

@vince-fugnitto vince-fugnitto mentioned this issue Feb 3, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application file search issues related to the file search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akosyakov