Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code extension - menu when - condition with expression with config doesn't work #6135

Closed
amiramw opened this issue Sep 8, 2019 · 3 comments
Labels
bug bugs found in the application vscode issues related to VSCode compatibility

Comments

@amiramw
Copy link
Member

amiramw commented Sep 8, 2019

Description

When runnign vscode extension that has menu with when expression, the condition with config is ignored.
It should be supproted according to this: https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts

And it works fine in VS Code.

Reproduction Steps

  • Build vsix out of https://github.com/amiramw/vscode-config-when
  • Load the vsix
  • Disable setting editor.minimap.enabled
  • Context menu on some file with suffix .workflow still shows Open Workflow Editor command even though the expression in package.json is resourceFilename =~ /.+.workflow/ && config.editor.minimap.enabled != true

This scenario works fine in VS Code.

OS and Theia version:
All

Diagnostics:
N/A

@akosyakov akosyakov added bug bugs found in the application vscode issues related to VSCode compatibility labels Sep 9, 2019
@akosyakov
Copy link
Member

@amiramw Could you please try against #5901? We had the similar issue #6102 and it seems to be resolved by #5901

@amiramw
Copy link
Member Author

amiramw commented Sep 10, 2019

yes. it is resolved by #5901

@akosyakov
Copy link
Member

resolved by #5901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

2 participants