Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace java and debug native with vscode extensions #6183

Closed
akosyakov opened this issue Sep 13, 2019 · 5 comments
Closed

replace java and debug native with vscode extensions #6183

akosyakov opened this issue Sep 13, 2019 · 5 comments
Assignees
Labels
vscode issues related to VSCode compatibility
Milestone

Comments

@akosyakov
Copy link
Member

akosyakov commented Sep 13, 2019

Motivated by #6113 (comment)

  • theia-apps should be updated: use vscode extensions instead of native theia-ide/theia-apps#239
  • java, java-debug, nodes-debug extensions should be removed and replaced by auto-downloading corresponding vscode extensions into plugins folder for testing purporses with example apps
  • a record in CHANGELOG should be added to explain for end products:
    • how to switch to use vscode extensions
    • how to use yarn resolutions to keep using old native extensions

cc @marcdumais-work

@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Sep 13, 2019
@vince-fugnitto
Copy link
Member

Do we want to clean up before this week's release?

@akosyakov
Copy link
Member Author

@vince-fugnitto i don't think anyone on our side has time for, if you can go ahead, if not we can do it later

@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 25, 2019

Make sure to not download from the vscode marketplace. It's a no-no.

@marcdumais-work
Copy link
Contributor

marcdumais-work commented Sep 25, 2019

@tsmaeder small typo I think: "now" -> "not", but the idea is correct. We can use the links currently in place in the theia extensions, that pull from GitHub releases:

https://github.com/eclipse-theia/theia/blob/master/packages/debug-nodejs/package.json#L52-L53
https://github.com/eclipse-theia/theia/blob/master/packages/java-debug/package.json#L53

edit: Or vscode built-in extension(s) if appropriate, which may be the case for node-debug IIUC.

@vince-fugnitto
Copy link
Member

Closed by #6933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

4 participants