From 499deffb108c9918b7a0f3a3280ea3531249f06c Mon Sep 17 00:00:00 2001 From: Jonah Iden Date: Wed, 11 Jan 2023 12:59:53 +0000 Subject: [PATCH 1/2] fixed debug hover widget overflowing when tree to big Signed-off-by: Jonah Iden --- packages/debug/src/browser/editor/debug-hover-widget.ts | 4 ++++ packages/debug/src/browser/style/index.css | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/debug/src/browser/editor/debug-hover-widget.ts b/packages/debug/src/browser/editor/debug-hover-widget.ts index e073191cd2bc5..2def0d59ae4fc 100644 --- a/packages/debug/src/browser/editor/debug-hover-widget.ts +++ b/packages/debug/src/browser/editor/debug-hover-widget.ts @@ -97,6 +97,10 @@ export class DebugHoverWidget extends SourceTreeWidget implements monaco.editor. this.contentNode.className = 'theia-debug-hover-content'; this.domNode.appendChild(this.contentNode); + + // for stopping scroll events from contentNode going to the editor + this.contentNode.addEventListener("wheel", e => e.stopPropagation()); + this.editor.getControl().addContentWidget(this); this.source = this.hoverSource; this.toDispose.pushAll([ diff --git a/packages/debug/src/browser/style/index.css b/packages/debug/src/browser/style/index.css index be675ba0db906..68a694ee7ed0e 100644 --- a/packages/debug/src/browser/style/index.css +++ b/packages/debug/src/browser/style/index.css @@ -338,7 +338,7 @@ /** Hover */ .theia-debug-hover { - display: flex; + display: flex !important; flex-direction: column; border: 1px solid var(--theia-editorHoverWidget-border); background: var(--theia-editorHoverWidget-background); From d68ec9c484fe4c21027f5a9d0b7ac694d725acd9 Mon Sep 17 00:00:00 2001 From: Jonah Iden Date: Wed, 11 Jan 2023 15:59:54 +0100 Subject: [PATCH 2/2] linting issues fixed Signed-off-by: Jonah Iden --- packages/debug/src/browser/editor/debug-hover-widget.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/debug/src/browser/editor/debug-hover-widget.ts b/packages/debug/src/browser/editor/debug-hover-widget.ts index 2def0d59ae4fc..3ec57f795637e 100644 --- a/packages/debug/src/browser/editor/debug-hover-widget.ts +++ b/packages/debug/src/browser/editor/debug-hover-widget.ts @@ -97,9 +97,8 @@ export class DebugHoverWidget extends SourceTreeWidget implements monaco.editor. this.contentNode.className = 'theia-debug-hover-content'; this.domNode.appendChild(this.contentNode); - - // for stopping scroll events from contentNode going to the editor - this.contentNode.addEventListener("wheel", e => e.stopPropagation()); + // for stopping scroll events from contentNode going to the editor + this.contentNode.addEventListener('wheel', e => e.stopPropagation()); this.editor.getControl().addContentWidget(this); this.source = this.hoverSource;