Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider to pack as vsix and publish as GitHub releases #5

Closed
akosyakov opened this issue Jul 23, 2019 · 4 comments
Closed

consider to pack as vsix and publish as GitHub releases #5

akosyakov opened this issue Jul 23, 2019 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@akosyakov
Copy link
Member

There are 2 gotchas:

  • VS Code team does not package these extensions, so it could be impossible because of missing attributes or files
  • pulling from GitHub require GitHub token compare to npm
@marcdumais-work
Copy link
Contributor

@akosyakov you mention potential downsides, but what would be the main advantage(s) to distribute these built-in extensions as vsix file(s) vs NPM packages?

@akosyakov
Copy link
Member Author

There are probably could be 2:

  • less magic in the plugin system, if you can just consume vsix
  • the same packaging as non built-in extensions

@akosyakov
Copy link
Member Author

Another reason to do it: eclipse-theia/theia#6207

@akosyakov
Copy link
Member Author

We go with publishing to Open VSX Registry instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants