Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR 1186 follow-ups w.r.t. validation #1206

Open
danielpeintner opened this issue Dec 21, 2023 · 1 comment
Open

PR 1186 follow-ups w.r.t. validation #1206

danielpeintner opened this issue Dec 21, 2023 · 1 comment

Comments

@danielpeintner
Copy link
Member

danielpeintner commented Dec 21, 2023 •
edited
Loading

I think we can merge this PR as is and look at some points raised in the comments later

  • @relu91 check implementation in browser
  • @danielpeintner function getLastValidationErrors() not in any case what one would expect ...

Originally posted by @danielpeintner in #1186 (comment)
@danielpeintner danielpeintner mentioned this issue Dec 21, 2023
Merged
@JKRhb
Copy link
Member

JKRhb commented Dec 21, 2023

Another thing that needs to be added is some validation logic for the TDD Thing Description itself (e.g., ensuring that ThingDirectory is present in the @type field). I only thought about that shortly before #1186 got merged :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielpeintner @JKRhb