Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Convert unhandledRejection to uncaughtException #1299

Open
danielpeintner opened this issue Jul 8, 2024 · 0 comments · May be fixed by #1300
Open

[test] Convert unhandledRejection to uncaughtException #1299

danielpeintner opened this issue Jul 8, 2024 · 0 comments · May be fixed by #1300
Labels
binding-http Issues related to http protocol binding

Comments

@danielpeintner
Copy link
Member

As mentioned in #1298 by @relu91 (see here #1298 (comment)) mocha ignores the new nodejs mechanism of reporting async unhandled exceptions.

We need to set
mocha --unhandled-rejections=strict --require ts-node/register --extension ts
in all package.json files.

Doing so for binding-http shows already some issues.
see #1298 (comment)

plus: we also might want to rework the test introduced in #1298 by simply doing something like
(await text(data.body)).should.eql("Test event");

@relu91 relu91 added the binding-http Issues related to http protocol binding label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding-http Issues related to http protocol binding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants