Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus 1.6.0 #575

Merged
merged 4 commits into from
Aug 20, 2020
Merged

Quarkus 1.6.0 #575

merged 4 commits into from
Aug 20, 2020

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Aug 18, 2020

Signed-off-by: Vitaliy Gulyy [email protected]

What does this PR do?

  • Introduces Quarkus extension 1.6.0

Devfile to test


---
apiVersion: 1.0.0
metadata:
  name: java-quarkus-1.6.0
projects:
  -
    name: java-web-spring
    source:
      type: git
      location: "https://github.com/spring-projects/spring-petclinic.git"
      commitId: 4953f87917b449a404a7f1f4e2457836b9eafbbc

components:
  -
    type: chePlugin
    reference: >-
      https://raw.githubusercontent.com/vitaliy-guliy/che-plugin-registry/quarkus-1.6.0/v3/plugins/redhat/quarkus-java11/1.6.0/meta.yaml
    preferences:
      java.project.importOnFirstTimeStartup: 'automatic'

Signed-off-by: Vitaliy Gulyy <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Aug 18, 2020

@vitaliy-guliy Happy Path PR check [build 229] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link URL
console https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/229/console
artifacts http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/229/

Depending on failure reason, the artifacts or deployment may not be present.

@che-bot
Copy link
Contributor

che-bot commented Aug 18, 2020

@vitaliy-guliy Happy Path PR check [build 231] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link URL
console https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/231/console
artifacts http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/231/

Depending on failure reason, the artifacts or deployment may not be present.

@svor
Copy link
Contributor

svor commented Aug 18, 2020

@ericwill should we update vscode-extensions.json by hand?

@ericwill
Copy link
Contributor

@ericwill should we update vscode-extensions.json by hand?

Yes.

Copy link
Contributor

@ericwill ericwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @svor mentioned, please also update the revision field in the vscode-extensions.json file

firstPublicationDate: "2020-08-18"
spec:
containers:
- image: "quay.io/eclipse/che-sidecar-java:11-f76ca45"
Copy link
Contributor

@ericwill ericwill Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the latest che-sidecar-java:11 image listed in the vscode-extension.json file for the quarkus extension.

@benoitf
Copy link
Contributor

benoitf commented Aug 19, 2020

I'm a bit worried that by bumping vscode-java, users will have a default prompt about importing their java projects

is there a way to apply the configuration from meta.yaml ? and not to patch every devfile by adding

    preferences:
      java.project.importOnFirstTimeStartup: 'automatic'

@vitaliy-guliy
Copy link
Contributor Author

I'm a bit worried that by bumping vscode-java, users will have a default prompt about importing their java projects

is there a way to apply the configuration from meta.yaml ? and not to patch every devfile by adding

    preferences:
      java.project.importOnFirstTimeStartup: 'automatic'

I tried to do it before, but wasn't lucky.
Adding preferences from plugin is not supported and it doesn't described in the plugin spec
https://github.com/eclipse/che-plugin-registry#plugin-meta-yaml-structure

But.. we can write a plugin. Which will read all the plugin meta.yamls and add the corresponding preferences if such present.
Or just extend the functionality of workspace plugin.

@vitaliy-guliy
Copy link
Contributor Author

@ericwill done with vscode-extensions.json and with container version

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2020

@vitaliy-guliy Happy Path PR check [build 232] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link URL
console https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/232/console
artifacts http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/232/

Depending on failure reason, the artifacts or deployment may not be present.

@vitaliy-guliy
Copy link
Contributor Author

[ci-test]

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2020

@vitaliy-guliy Happy Path PR check [build 233] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link URL
console https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/233/console
artifacts http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/233/

Depending on failure reason, the artifacts or deployment may not be present.

@ericwill
Copy link
Contributor

Do we need the latest version of vscode-java? IMO it shouldn't be newer than what we already have in Che, unless absolutely necessary.

Signed-off-by: Vitaliy Gulyy <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2020

@vitaliy-guliy Happy Path PR check [build 235] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link URL
console https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/235/console
artifacts http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/235/

Depending on failure reason, the artifacts or deployment may not be present.

@ericwill ericwill merged commit 7608931 into eclipse-che:master Aug 20, 2020
@che-bot che-bot added this to the 7.18 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants