-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarkus 1.6.0 #575
Quarkus 1.6.0 #575
Conversation
Signed-off-by: Vitaliy Gulyy <[email protected]>
@vitaliy-guliy Happy Path PR check [build 229] failed.Re-trigger by
Depending on failure reason, the artifacts or deployment may not be present. |
Signed-off-by: Vitaliy Gulyy <[email protected]>
@vitaliy-guliy Happy Path PR check [build 231] failed.Re-trigger by
Depending on failure reason, the artifacts or deployment may not be present. |
@ericwill should we update vscode-extensions.json by hand? |
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @svor mentioned, please also update the revision field in the vscode-extensions.json file
firstPublicationDate: "2020-08-18" | ||
spec: | ||
containers: | ||
- image: "quay.io/eclipse/che-sidecar-java:11-f76ca45" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the latest che-sidecar-java:11 image listed in the vscode-extension.json file for the quarkus extension.
I'm a bit worried that by bumping vscode-java, users will have a default prompt about importing their java projects is there a way to apply the configuration from meta.yaml ? and not to patch every devfile by adding
|
I tried to do it before, but wasn't lucky. But.. we can write a plugin. Which will read all the plugin meta.yamls and add the corresponding preferences if such present. |
Signed-off-by: Vitaliy Gulyy <[email protected]>
@ericwill done with vscode-extensions.json and with container version |
@vitaliy-guliy Happy Path PR check [build 232] failed.Re-trigger by
Depending on failure reason, the artifacts or deployment may not be present. |
[ci-test] |
@vitaliy-guliy Happy Path PR check [build 233] failed.Re-trigger by
Depending on failure reason, the artifacts or deployment may not be present. |
Do we need the latest version of |
Signed-off-by: Vitaliy Gulyy <[email protected]>
@vitaliy-guliy Happy Path PR check [build 235] failed.Re-trigger by
Depending on failure reason, the artifacts or deployment may not be present. |
Signed-off-by: Vitaliy Gulyy [email protected]
What does this PR do?
Devfile to test