Add Key Binding Scheme Selector #3857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnaud Kervern <[email protected]>
|
Can one of the admins verify this patch? |
|
ci-build |
benoitf
added
kind/enhancement
|
Build # 1742 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1742/ to view the results. |
|
Any news? |
vparfonov
reviewed
Jan 31, 2017
|
|
||
| String isGlobal(); | ||
|
|
||
| String selectionLabel(); |
There was a problem hiding this comment.
@akervern
Add some javadoc for selection* fields, please.
vparfonov
added
status/pending-merge
and removed
status/code-review
|
Two questions about this:
|
|
From my point of view; |
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* Add Key Binding Scheme Selector Signed-off-by: Arnaud Kervern <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Here is a primarily work before trying to contribute an Eclipse based Key Binding:
This PR add the ability to switch between registered Key Bindings Scheme.
org.eclipse.che.ide.keybinding.KeyBindingManagerworked. Using a Map of registered schemes instead of manager's attributes.org.eclipse.che.ide.keybinding.KeyBindingManagerIn the key binding popup:
https://github.com/codenvy/qa/pull/581
Changelog
org.eclipse.che.ide.api.keybinding.KeyBindingAgent#getEclipsehas been deprecated: useKeyBindingAgent#getActive()orKeyBindingAgent#getScheme(String)if you want to access a SchemeRelease Notes
We have deprecated
org.eclipse.che.ide.api.keybinding.KeyBindingAgent#getEclipse. You can access a scheme viaKeyBindingAgent#getActive()orKeyBindingAgent#getScheme(String).