Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-3811: move js file to the che-lib/che-orion-editor #3979

Merged
merged 5 commits into from
Feb 7, 2017
Merged

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Feb 1, 2017

What does this PR do?

Move all JS files of Orion from plugin-orion to the che-lib repository. This allow as avoid problem with compilation plugin-orion on Windows OS because during compilation we modify some JS files with using patch utils which not available on Windows OS machine.
So for now we move this step to the che-lib, by default our contributors don't need modify this code.

Related to: eclipse-che/che-lib#18

What issues does this PR fix or reference?

#3811

Changelog

Move all JS files of Orion from plugin-orion to the che-lib repository

@vparfonov vparfonov self-assigned this Feb 1, 2017
@vparfonov vparfonov added kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/next team/ide labels Feb 1, 2017
@codenvy-ci
Copy link

Build # 1835 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1835/ to view the results.

@vparfonov
Copy link
Contributor Author

ci-build

@codenvy-ci
Copy link

Build # 1842 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1842/ to view the results.

@bmicklea bmicklea requested review from JamesDrummond and removed request for bmicklea February 2, 2017 15:28
@vparfonov
Copy link
Contributor Author

@JamesDrummond any changes in docs not required, this pretty internal stuff. Script still be loaded in same way by IDE application, we just change location for avoiding compiling problem on Windows machine.

@vparfonov vparfonov added this to the 5.3.0 milestone Feb 7, 2017
Signed-off-by: Vitalii Parfonov <[email protected]>
@vparfonov vparfonov merged commit 832bb42 into master Feb 7, 2017
@vparfonov vparfonov deleted the che#3811 branch February 7, 2017 17:27
@codenvy-ci
Copy link

Build # 1904 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1904/ to view the results.

@JamesDrummond JamesDrummond mentioned this pull request Feb 17, 2017
9 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants