CHE-3064: Add log errors on pre-destroy phase #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1843/ |
akorneta
approved these changes
Feb 1, 2017
| @@ -21,12 +23,8 @@ | |||
| void onError(Object instance, Method method, Throwable error); | |||
|
|
|||
| /** | |||
| * Implementation of DestroyErrorHandler that ignore errors, e.g. such behaviour is required for annotation {@link | |||
| * Implementation of DestroyErrorHandler that log errors, e.g. such behaviour is required for annotation {@link | |||
There was a problem hiding this comment.
actually @javax.annotation.PreDestroy does require the logging of errors and provided documentation can confused a bit.
skabashnyuk
approved these changes
Feb 2, 2017
|
Build # 1891 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1891/ to view the results. |
vinokurig
pushed a commit
that referenced
this pull request
Feb 14, 2017
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Log the errors on pre-destroy phase
What issues does this PR fix or reference?
#3064
Changelog
Errors that might happen on application server stopping, will be logged.
Release Notes
Technical debt N/A