[cli] Fix cli tests by reworking how integration tests are launched #3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We used OS path mounted into container path (it makes issues as on Windows we don’t have these paths) - Now use /dockerfiles path inside the container - add skip check for nightlies or it was downloading new images while testing the current nightly - add —rm for cleaning containers at the end of the start - introduce of some asserts instead of custom checks Change-Id: I352d7c475796df641c1e34f461c55a76c897922d Signed-off-by: Florent BENOIT <[email protected]>
benoitf
added
kind/bug
TylerJewell
approved these changes
Feb 1, 2017
riuvshin
approved these changes
Feb 1, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1844/ |
Change-Id: I36e2527c2c334221ed2bea0fe99b8ab75ce02ea7 Signed-off-by: Florent BENOIT <[email protected]>
Signed-off-by: Tyler Jewell [email protected] <[email protected]>
TylerJewell
approved these changes
Feb 2, 2017
TylerJewell
added
the
severity/P2
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1849/ |
benoitf
removed
the
status/code-review
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…clipse-che#3991) * Fix eclipse-che#3980 by reworking how integration tests are launched - We used OS path mounted into container path (it makes issues as on Windows we don’t have these paths) - Now use /dockerfiles path inside the container - add skip check for nightlies or it was downloading new images while testing the current nightly - add —rm for cleaning containers at the end of docker run - introduce of some asserts instead of custom checks - Fix windows issue (like path with spaces) - Fix teardown of che start tests Change-Id: I352d7c475796df641c1e34f461c55a76c897922d Signed-off-by: Florent BENOIT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
#3980
Changelog
Use
/dockerfilespath inside CLI container for launchAdd skip check for nightlies
Add
--rmfor cleaning containers at the end of the startIntroduce asserts instead of custom checks
Release Notes
N/A for bugs
Docs PR
N/A for bugs