-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple testing framework API from Java test specific frameworks #3999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bartlomiej Laczkowski <[email protected]>
Signed-Off-By: Bartlomiej Laczkowski <[email protected]>
Signed-off-by: Bartlomiej Laczkowski <[email protected]>
Signed-off-by: Bartlomiej Laczkowski <[email protected]>
Signed-off-by: Bartlomiej Laczkowski <[email protected]>
Signed-off-by: Bartlomiej Laczkowski <[email protected]>
Signed-off-by: Bartlomiej Laczkowski <[email protected]>
Signed-off-by: Vitalii Parfonov <[email protected]>
Signed-off-by: Vitalii Parfonov <[email protected]>
vparfonov
changed the title
Bartlomiej laczkowski unit testing
Decouple testing framework API from Java test specific frameworks
Feb 2, 2017
skabashnyuk
approved these changes
Feb 2, 2017
wsagent/pom.xml
Outdated
@@ -35,6 +35,8 @@ | |||
<module>che-core-api-debug-shared</module> | |||
<module>che-core-api-languageserver</module> | |||
<module>che-core-api-languageserver-shared</module> | |||
<module>che-core-api-testing</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format
Signed-off-by: Vitalii Parfonov <[email protected]>
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1853/ |
bmicklea
approved these changes
Feb 2, 2017
vparfonov
added
the
kind/enhancement
A feature request - must adhere to the feature request template.
label
Feb 2, 2017
Signed-off-by: Vitalii Parfonov <[email protected]>
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1858/ |
9 tasks
JamesDrummond
added
the
kind/task
Internal things, technical debt, and to-do tasks to be performed.
label
Feb 17, 2017
JamesDrummond
removed
kind/enhancement
A feature request - must adhere to the feature request template.
sprint/next
labels
Feb 17, 2017
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…lipse-che#3999) * Decouple testing framework core from Java specific test frameworks. Signed-off-by: Bartlomiej Laczkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a proposal for decoupling testing framework core API from Java specific testing frameworks.
What issues does this PR fix or reference?
#3452
Previous behavior
In current state all of the testing frameworks that are Java specific are tightly coupled with the testing framework core API, which complicates "straight-forward" adding of new testing frameworks (i.e. PHPUnit).
New behavior
That's more or less the general description of the changes that I have made. I am eager to answer all of the possible questions related to the details.
Signed-off-by: Bartlomiej Laczkowski [email protected]
Changelog
Decoupling of testing framework core API from Java specific testing frameworks implementation.
Release Notes:
N/A refactoring of existing code.
Docs PR:
None : same behavior than before