-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Simpler networking config explanation & command line overrides #4114
Conversation
Signed-off-by: Tyler Jewell <[email protected]>
Signed-off-by: Tyler Jewell <[email protected]>
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1943/ |
Signed-off-by: Tyler Jewell <[email protected]>
Signed-off-by: Tyler Jewell <[email protected]>
Signed-off-by: Tyler Jewell <[email protected]>
@eivantsov - you may want to run a quick test. I did a series of tests to demonstrate that CHE_HOST and CHE_PORT provided on the command line will now override any setting provided in the environment file. |
Signed-off-by: Tyler Jewell <[email protected]>
Build # 1945 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1945/ to view the results. |
Signed-off-by: Tyler Jewell <[email protected]>
Signed-off-by: Tyler Jewell <[email protected]>
Signed-off-by: Tyler Jewell <[email protected]>
Signed-off-by: Tyler Jewell <[email protected]>
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1948/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR does not work for me on Mac
I've build base cli and init images from branch started che, then I tried
docker run ... restart --skip:nightly --skip:pull -e CHE_PORT=9090
and nothing changed
@riuvshin syntax had a mistake - the |
tested on mac and ubuntu - works |
tesed on digital ocean, it works but we have issue with generation secure random which takes up to 10 minutes on instances with low entroy.
|
I've added |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1971/ |
…clipse-che#4114) * Simpler networking config explanation & command line overrides
What does this PR do?
Adding improvements on configuring Che for common scenarios. We have seen that users who provide
CHE_HOST
orCHE_PORT
on the command line want that to override the values ofche.env
. Today, it is the reverse where values in the environment file would override the command line.This set of changes applies an algorithm that will take any values of
CHE_*
or{CHE_PRODUCT_NAME}_*
that are passed on the command line and insert those parameters into theconfig
method, generating an instance-specific.env
file which will be used by the Che server when it is started. If this is ARTIK or CODENVY, it will load both the CHE_* and ARTIK_* and CODENVY_* variables, so that anything that we provide as a parameter in a *.env file can now be overridden on the command line.Matching PRs:
Changelog
Make command-line
CHE_HOST
orCHE_PORT
overrideche.env
values.Release Notes
Docker command-line environment variables
CHE_HOST
orCHE_PORT
overrideche.env
values.Docs PR
eclipse-che/che-docs#137