Cleanup volumes after docker_compose containers stop #4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
added
the
kind/bug
TylerJewell
approved these changes
Feb 14, 2017
benoitf
approved these changes
Feb 14, 2017
garagatyi
approved these changes
Feb 14, 2017
skabashnyuk
approved these changes
Feb 14, 2017
|
@mshaposhnik - in your title you say this is an option but it sounds like this is something that will always happen when you stop with CLI, is that right? |
|
@bmicklea IMHO it's more "enable flag" |
|
@bmicklea Yes, techinaclly it's a docker-compose option. But we will use it permanently. |
mshaposhnik
changed the title
|
Is it possible to disable this and would anyone want to? |
|
@bmicklea very unlikely |
bmicklea
approved these changes
Feb 14, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1968/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
cmd_stopto cleanup volumes after container stopped.What issues does this PR fix or reference?
codenvy/codenvy#1477
Changelog
Fixed CLI to cleanup volumes after container stopped.
Release Notes
In our quest for constant improvement we've tweaked the
stopcommand in the CLI to cleanup volumes after the containers are stopped.Docs PR
N/A