Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse terminal slave command by exec agent #4148

Merged
merged 1 commit into from
Feb 15, 2017

Conversation

voievodin
Copy link
Contributor

@voievodin voievodin commented Feb 15, 2017

What does this PR do?

Fixed initialization sequence for process.ShellInterpreter, so exec-agent reuses SHELL_INTERPRETER from terminal agent boot script

Changelog

Reuse $SHELL_INTERPRETER as shell interpreter for exec-agent

Release Notes

N/A

Docs PR

N/A

@voievodin voievodin added the kind/bug Outline of a bug - must adhere to the bug report template. label Feb 15, 2017
@voievodin voievodin self-assigned this Feb 15, 2017
@voievodin
Copy link
Contributor Author

voievodin commented Feb 15, 2017

@JamesDrummond | @eivantsov verify cl please

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 15, 2017
@benoitf benoitf added status/pending-merge and removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Feb 15, 2017
@voievodin voievodin merged commit 1ba4369 into master Feb 15, 2017
@voievodin voievodin deleted the use_right_shell_interpreter branch February 15, 2017 16:51
@voievodin voievodin added this to the 5.3.0 milestone Feb 15, 2017
@codenvy-ci
Copy link

Build # 1982 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1982/ to view the results.

@JamesDrummond JamesDrummond mentioned this pull request Feb 17, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants