Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Apache Camel LSP support #8648

Merged
merged 2 commits into from
Feb 7, 2018
Merged

Introduce Apache Camel LSP support #8648

merged 2 commits into from
Feb 7, 2018

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Feb 7, 2018

What does this PR do?

It brings Apache Camel LSP on top of XML files that are using Apache Camel namespace
camel-lsp

LSP server is using Apache 2 License
https://github.com/lhein/camel-language-server/blob/master/LICENSE

What issues does this PR fix or reference?

openshiftio/openshift.io#2024

Release Notes

Add Apache Camel LSP to existing LSP list

apupier and others added 2 commits February 7, 2018 09:54
Change-Id: I936fc1ce11766f6490ceaaefe7d3b0757f6c0301
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Feb 7, 2018
@benoitf benoitf self-assigned this Feb 7, 2018
@codenvy-ci
Copy link

Build # 4454 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4454/ to view the results.

@benoitf
Copy link
Contributor Author

benoitf commented Feb 7, 2018

@codenvy-ci
Copy link

Build # 4455 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4455/ to view the results.

@benoitf
Copy link
Contributor Author

benoitf commented Feb 7, 2018

@riuvshin it seems jenkins slave node is quite unstable

@riuvshin
Copy link
Contributor

riuvshin commented Feb 7, 2018

I do not see any issue with slave, in both build we had failed tests... maybe tests are not much stable, but anyways I will check ci slave

@benoitf
Copy link
Contributor Author

benoitf commented Feb 7, 2018

ci-build


touch ${LS_LAUNCHER}
chmod +x ${LS_LAUNCHER}
echo "java -jar ${LS_DIR}/camel-lsp-server.jar" > ${LS_LAUNCHER}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does all images contain java?
Should we check and echo some message if so?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolusha AFAIK yes for ws-agent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and without ws-agent the LS is useless

@codenvy-ci
Copy link

@benoitf benoitf merged commit 307ee4f into master Feb 7, 2018
@benoitf benoitf deleted the lsp-camel branch February 7, 2018 13:04
@benoitf benoitf added this to the 6.1.0 milestone Feb 7, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants