We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If the gradle wrapper is disabled and no gradle home variable is defined, the GradleProjectImporter.getGradleDistribution returns the wrapper anyways, instead of the default gradle distro (DEFAULT_DISTRIBUTION == GradleDistribution.fromBuild() == wrapper): https://github.com/eclipse/eclipse.jdt.ls/blob/43a78f7c339f41d7cb3c4d6d23e3fe18b74c29ef/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleProjectImporter.java#L120-L124.
And if the GradleProjectImporterTest.testDisableGradleWrapper runs in an environment which defines a gradle home, then the test fails L109:
https://github.com/eclipse/eclipse.jdt.ls/blob/43a78f7c339f41d7cb3c4d6d23e3fe18b74c29ef/org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/managers/GradleProjectImporterTest.java#L107-L109
The text was updated successfully, but these errors were encountered:
should be
DEFAULT_DISTRIBUTION = GradleDistribution.forVersion(GradleVersion.current().getVersion());
Sorry, something went wrong.
snjeza
Successfully merging a pull request may close this issue.
If the gradle wrapper is disabled and no gradle home variable is defined, the GradleProjectImporter.getGradleDistribution returns the wrapper anyways, instead of the default gradle distro (DEFAULT_DISTRIBUTION == GradleDistribution.fromBuild() == wrapper):
https://github.com/eclipse/eclipse.jdt.ls/blob/43a78f7c339f41d7cb3c4d6d23e3fe18b74c29ef/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleProjectImporter.java#L120-L124.
And if the GradleProjectImporterTest.testDisableGradleWrapper runs in an environment which defines a gradle home, then the test fails L109:
https://github.com/eclipse/eclipse.jdt.ls/blob/43a78f7c339f41d7cb3c4d6d23e3fe18b74c29ef/org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/managers/GradleProjectImporterTest.java#L107-L109
The text was updated successfully, but these errors were encountered: