Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find implementation doesn't work on classes #1098

Closed
fbricon opened this issue Jul 8, 2019 · 4 comments · Fixed by #1150
Closed

Find implementation doesn't work on classes #1098

fbricon opened this issue Jul 8, 2019 · 4 comments · Fixed by #1150
Assignees
Labels

Comments

@fbricon
Copy link
Contributor

fbricon commented Jul 8, 2019

If you have a class Foo, and a class Bar like:

class Bar {
   Foo foo = new Foo();
}

find implementation on Foo, doesn't find the actual Foo class!

@fbricon fbricon added the bug label Jul 8, 2019
@snjeza
Copy link
Contributor

snjeza commented Jul 8, 2019

Related PR - redhat-developer/vscode-java#257

@fbricon
Copy link
Contributor Author

fbricon commented Jul 8, 2019

Whether codelenses are enabled and/or only working for interfaces/abstract classes should not affect the explicit calls to search for implementations

@snjeza
Copy link
Contributor

snjeza commented Jul 8, 2019

Could you try the following:

class Bar {
   Foo foo = new Foo() {};
}

@testforstephen
Copy link
Contributor

For this case, if the class doesn't find any subtype, then go to definition instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants