Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert to static import incorrectly removes import #1203

Closed
yyoncho opened this issue Oct 8, 2019 · 5 comments · Fixed by #2003
Closed

convert to static import incorrectly removes import #1203

yyoncho opened this issue Oct 8, 2019 · 5 comments · Fixed by #2003
Labels
bug upstream
Milestone
Early March 2022

Comments

@yyoncho
Copy link
Contributor

yyoncho commented Oct 8, 2019

See emacs-lsp/lsp-java#158 for steps to reproduce and sample project.
@yyoncho yyoncho mentioned this issue Oct 8, 2019
Closed
@fbricon
Copy link
Contributor

fbricon commented Oct 8, 2019

Can you provide a sample project and steps to reproduce the issue?

@yyoncho
Copy link
Contributor Author

yyoncho commented Oct 8, 2019 •
edited
Loading

Use https://github.com/yauhen-l/lsp-java-static-import-issue

Edit: Like I mentioned in the PR description the steps are present in the original but report.

@fbricon
Copy link
Contributor

fbricon commented Oct 16, 2019

Thanks, the problem can also be reproduced in upstream Eclipse JDT, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=542653

@fbricon
Copy link
Contributor

fbricon commented Oct 16, 2019

The proposed fix in https://git.eclipse.org/r/#/c/136212/3/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/QuickAssistProcessor.java, once finalized, would have to be ported back to jdt.ls.

@yyoncho yyoncho mentioned this issue Oct 22, 2019
Closed
@rgrunber rgrunber added this to the End February 2022 milestone Jan 29, 2022
@rgrunber
Copy link
Contributor

rgrunber commented Jan 29, 2022 •
edited
Loading

The bug, and PR from 2019 were merged about 2 weeks ago. We should copy the changes over and confirm it resolves the issue.

@rgrunber rgrunber mentioned this issue Jan 29, 2022
Open
rgrunber added a commit to rgrunber/eclipse.jdt.ls that referenced this issue Feb 1, 2022
@rgrunber
Convert to static import incorrectly removes an import.
1b5024e 
- Fixes eclipse-jdtls#1203
- Fixed upstream at https://eclip.se/542653

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber rgrunber mentioned this issue Feb 1, 2022
Merged
rgrunber added a commit to rgrunber/eclipse.jdt.ls that referenced this issue Feb 2, 2022
@rgrunber
Convert to static import incorrectly removes an import.
de37586 
- Fixes eclipse-jdtls#1203
- Fixed upstream at https://eclip.se/542653
- Add testcase from upstream

Signed-off-by: Roland Grunberg <[email protected]>
rgrunber added a commit to rgrunber/eclipse.jdt.ls that referenced this issue Feb 4, 2022
@rgrunber
Convert to static import incorrectly removes an import.
129a955 
- Fixes eclipse-jdtls#1203
- Fixed upstream at https://eclip.se/542653
- Add testcase from upstream

Signed-off-by: Roland Grunberg <[email protected]>
rgrunber added a commit that referenced this issue Feb 5, 2022
@rgrunber
Convert to static import incorrectly removes an import.
47ee1de 
- Fixes #1203
- Fixed upstream at https://eclip.se/542653
- Add testcase from upstream

Signed-off-by: Roland Grunberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug upstream
Projects
None yet
Milestone
Early March 2022
Development

Successfully merging a pull request may close this issue.

Convert to static import incorrectly removes an import. rgrunber/eclipse.jdt.ls
3 participants
@fbricon @rgrunber @yyoncho