Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclipse.jdt.ls build fails due to breaking changes in LSP4J #1340

Closed
snjeza opened this issue Feb 1, 2020 · 1 comment · Fixed by #1342
Closed

eclipse.jdt.ls build fails due to breaking changes in LSP4J #1340

snjeza opened this issue Feb 1, 2020 · 1 comment · Fixed by #1342

Comments

@snjeza
Copy link
Contributor

snjeza commented Feb 1, 2020

See https://ci.eclipse.org/ls/job/jdt-ls-master/807/console

The error is caused by changes in lsp4j API:

  • Parameter of textDocument/signatureHelp changed from TextDocumentPositionParams position to SignatureHelpParams params
@woojoovove
Copy link

Hi, I encountered the same issue and It can be fixed by deleting "@OverRide" annotation of the method of

public CompletableFuture<SignatureHelp> signatureHelp(TextDocumentPositionParams position) {}

from

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java

my error message

[INFO] ------------------------------------------------------------------------

[INFO] Reactor Summary for JDT Language Server :: Parent 0.50.0-SNAPSHOT:

[INFO]

[INFO] JDT Language Server :: Parent ...................... SUCCESS [ 0.306 s]

[INFO] JDT Language Server :: Target Platform ............. SUCCESS [ 1.014 s]

[INFO] JDT Language Server :: Core ........................ FAILURE [ 5.033 s]

[INFO] JDT Language Server :: Tests ....................... SKIPPED

[INFO] JDT Language Server :: Product ..................... SKIPPED

[INFO] ------------------------------------------------------------------------

[INFO] BUILD FAILURE

[INFO] ------------------------------------------------------------------------

[INFO] Total time: 42.869 s

[INFO] Finished at: 2020-01-31T20:01:00+09:00

[INFO] ------------------------------------------------------------------------

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:1.6.0:compile (default-compile) on project org.eclipse.jdt.ls.core: Compilation failure: Compilation failure:

[ERROR] /home/XXX/XXX/eclipse-workspace/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java:[534]

[ERROR] public CompletableFuture signatureHelp(TextDocumentPositionParams position) {

[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[ERROR] The method signatureHelp(TextDocumentPositionParams) of type JDTLanguageServer must override or implement a supertype method

[ERROR] 1 problem (1 error)

[ERROR] -> [Help 1]

[ERROR]

[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.

[ERROR] Re-run Maven using the -X switch to enable full debug logging.

[ERROR]

[ERROR] For more information about the errors and possible solutions, please read the following articles:

[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

[ERROR]

[ERROR] After correcting the problems, you can resume the build with the command

[ERROR] mvn -rf :org.eclipse.jdt.ls.core

@fbricon fbricon changed the title eclipse.jdt.ls build fails eclipse.jdt.ls build fails due to breaking changes in LSP4J Feb 4, 2020
@fbricon fbricon added this to the End January 2020 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants