Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: duplicate implement method quick fixes #1942

Closed
0dinD opened this issue Nov 15, 2021 · 2 comments · Fixed by #1943
Closed

Regression: duplicate implement method quick fixes #1942

0dinD opened this issue Nov 15, 2021 · 2 comments · Fixed by #1943

Comments

@0dinD
Copy link
Contributor

0dinD commented Nov 15, 2021

While testing something else, I noticed a regression introduced by #1908. It seems like the "Add unimplemented methods" quick fix (and possibly others) are duplicated for every unimplemented method, and it's also taking a long time to compute quick fixes because of that.

implement-quick-fix-bug.mp4

Going back to the previous commit on master confirms that this bug was introduced with #1908.

@rgrunber
Copy link
Contributor

Maybe there are certain types of quick fixes that bypass the logic that attempts to avoid the duplication of their entries on the same line.

@snjeza
Copy link
Contributor

snjeza commented Nov 15, 2021

@0dinD @rgrunber Could you, please, review #1943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants