New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormattingOptions.isInsertSpaces=false is ignored during formatting requests #775

Closed

fbricon opened this issue Aug 29, 2018 · 0 comments

Assignees

Labels

Milestone

End August 2018

Contributor

fbricon commented Aug 29, 2018

When requesting to format a file or range using Tabs, i.e. options.isInsertSpaces() is false, the option is always ignored in:
https://github.com/eclipse/eclipse.jdt.ls/blob/44d351e41b64a336c85189af89009d79ca71fe31/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/FormatterHandler.java#L155-L158

fbricon added bug formatter labels

fbricon mentioned this issue

Fix for indention issue redhat-developer/vscode-java#617

Merged

fbricon added this to the End August 2018 milestone

fbricon self-assigned this

fbricon mentioned this issue

Ensure FormattingOptions.isInsertSpaces is not ignored when set to false #776

Merged

fbricon closed this as completed in #776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment