Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code action to generate constructors #972

Closed
testforstephen opened this issue Mar 27, 2019 · 6 comments
Closed

Add code action to generate constructors #972

testforstephen opened this issue Mar 27, 2019 · 6 comments
Assignees
@testforstephen @yaohaizh
Labels
code-actions enhancement
Milestone
End May 2019

Comments

@testforstephen
Copy link
Contributor

No description provided.

@testforstephen testforstephen mentioned this issue Mar 27, 2019
Closed
@fbricon
Copy link
Contributor

fbricon commented Apr 4, 2019

@testforstephen is everything we need available in jdt.core?

@fbricon
Copy link
Contributor

fbricon commented Apr 4, 2019

Depending on the availability of the upstream API, I'll let @yaohaizh target the proper milestone.

@testforstephen
Copy link
Contributor Author

Some part of the generation logic has moved to jdt.core, some part is still in jdt.ui. We may need submit a patch to move all of them to jdt.core.

@testforstephen
Copy link
Contributor Author

Create a gerrit patch to refactor the upstream code. https://git.eclipse.org/r/#/c/140580/

cc @rgrunber and @jjohnstn

@testforstephen testforstephen self-assigned this Apr 15, 2019
@fbricon
Copy link
Contributor

fbricon commented May 6, 2019 •
edited
Loading

So now that we merged #767, this issue is about adding the wizard to select the superclass constructors to generate, right?
Screen Shot 2019-05-06 at 6 42 04 PM

@testforstephen
Copy link
Contributor Author

It's also including adding wizard to select fields to generate constructors. Similar as Eclipse Generate Constructor using Fields....

@testforstephen testforstephen mentioned this issue May 14, 2019
Closed
@fbricon fbricon added this to the End May 2019 milestone May 14, 2019
@fbricon fbricon closed this as completed May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@testforstephen testforstephen

@yaohaizh yaohaizh

Labels
code-actions enhancement
Projects
None yet
Milestone
End May 2019
Development

Successfully merging a pull request may close this issue.

Add Code Action: Generate Constructors testforstephen/eclipse.jdt.ls
3 participants
@fbricon @testforstephen @yaohaizh