Refactor ChangeUtil: universal API converting Change to WorkspaceEdit #1106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for each type of
Change
, there's a corresponding public method located inChangeUtil
, which is not elegant or consistent. E.g.Anytime you want to convert a
Change
to aWorkspaceEdit
, you have to explicitly call the corresponding utility based on the type of Change.This PR refactors the utility and use
ChangeUtil.convertToWorkspaceEdit(Change change)
as the only entry to convertChange
toWorkspaceEdit
.