Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include folders to import #1200

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Include folders to import #1200

merged 1 commit into from
Oct 16, 2019

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Oct 7, 2019

Fixes redhat-developer/vscode-java#1084

Signed-off-by: Snjezana Peco [email protected]

Signed-off-by: Snjezana Peco <[email protected]>
@snjeza
Copy link
Contributor Author

snjeza commented Oct 7, 2019

@fbricon @maxandersen you can try the following:

"java.import.exclusions": [
        "**/node_modules/**",
        "**/.metadata/**",
        "**/archetype-resources/**",
        "**/META-INF/maven/**",
        "**/quarkus/**",
        "!**/quarkus",
        "!**/quarkus/build-parent",
        "!**/quarkus/bom",
        "!**/quarkus/bom/*",
        "!**/integration-tests",
        "!**/integration-tests/maven",
        "!**/devtools/*",
        "**/devtools/gradle"
    ]

You have to include a parent directory. The order is important.

vsix - https://raw.githubusercontent.com/snjeza/vscode-test/master/java-0.51.0.vsix

@fbricon
Copy link
Contributor

fbricon commented Oct 15, 2019

I understand why we need to do it (it seems .gitignore has similar limitations), but I'm not super fan of the required syntax, you still configure a lot of bloat. @maxandersen wdyt?

@maxandersen
Copy link

The syntax is common.

I’m not following your comment about configuring bloat ? In practice it should just be a few lines in most sane projects ?

@fbricon
Copy link
Contributor

fbricon commented Oct 16, 2019

bloat = you still need to add 9 lines of configuration to cover the 2 directories you mentioned you were interested in.

But if you're fine with that, I'm ok to merge it

@snjeza
Copy link
Contributor Author

snjeza commented Oct 16, 2019

bloat = you still need to add 9 lines of configuration to cover the 2 directories you mentioned you were interested in

We include 4 directories:

integration-tests/maven
devtools

and required directories

boom
builld-parent

and exclude

devtools/gradle

You can include only integration-tests/maven and devtools directories with the following:

"java.import.exclusions": [
        "**/node_modules/**",
        "**/.metadata/**",
        "**/archetype-resources/**",
        "**/META-INF/maven/**",
        "**/quarkus/**",
        "!**/quarkus",
        "!**/integration-tests",
        "!**/integration-tests/maven",
        "!**/devtools/*"
    ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include folders to import
3 participants