clean out-of-date fAST before updating new fActiveJavaElement #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan Zhang <[email protected]>
|
CodeAction also has the same issue. But since the out-of-date AST is soon updated by other handlers (e.g. publish diagnositics), in most cases users are not aware of it. See |
testforstephen
approved these changes
Apr 26, 2020
|
Do you have some instructions on how to reproduce this issue? |
|
OK I checked with the instructions from redhat-developer/vscode-java#1396 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When active java element changed( e.g. did open a new file), the cached
fASTwas out-of-date, thusSharedASTProvider.getAST(...)would return an wrong ComplilationUnit.