-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default JVM when importing gradle project #1430
Conversation
test this please |
Doesn't work. Client/Server message log
The JavaSE-1.8 runtime is set as default AFTER the project has been imported |
@fbricon I have updated the PR. |
@@ -789,7 +796,18 @@ public void projectConfigurationUpdate(TextDocumentIdentifier param) { | |||
public CompletableFuture<BuildWorkspaceStatus> buildWorkspace(boolean forceReBuild) { | |||
logInfo(">> java/buildWorkspace (" + (forceReBuild ? "full)" : "incremental)")); | |||
BuildWorkspaceHandler handler = new BuildWorkspaceHandler(pm); | |||
return computeAsyncWithClientProgress((monitor) -> handler.buildWorkspace(forceReBuild, monitor)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forcing resync on workspace build seems wrong. Moreover you should always decouple most of JDT.LS classes from build specific implementations.
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Snjezana Peco <[email protected]>
@fbricon I have updated the PR. |
Thanks @snjeza! |
Fixes redhat-developer/vscode-java#1426
You can test the following project:
gradle-test.zip
VS Code settings: redhat-developer/vscode-java#1426 (comment)
Signed-off-by: Snjezana Peco [email protected]