Enhanced IBuildSupport usage to support other build tools such as bazel #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
add to whitelist |
rgrunber
requested changes
Mar 19, 2021
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleProjectImporter.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/IBuildSupport.java
Show resolved
Hide resolved
LeonovecSergey
force-pushed
the
ibuildsupport
branch
2 times, most recently
from
78e02c5
to
8a3b615
Compare
|
Hi @rgrunber, |
Thanks, I'll have another look. Apologies for the delay. |
|
@rgrunber would be nice to have this one for 1.0 |
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ProjectUtils.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/commands/BuildPathCommand.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/BuildSupportManager.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/BuildSupportManager.java
Outdated
Show resolved
Hide resolved
Based on eclipse-jdtls#1674 Signed-off-by: Siarhei Leanavets <[email protected]>
Signed-off-by: Siarhei Leanavets <[email protected]>
…ich build support we want to check against the project. Signed-off-by: Siarhei Leanavets <[email protected]>
Signed-off-by: Siarhei Leanavets <[email protected]>
LeonovecSergey
force-pushed
the
ibuildsupport
branch
from
e25b661
to
b4523f1
Compare
Hi @testforstephen , thanks for the review. I have no idea why ProjectsManagerTest.testCancelUpdateJob is not working because on my laptop the build is fine. |
|
test this please |
|
testforstephen
approved these changes
Apr 14, 2021
|
Thanks @LeonovecSergey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced IBuildSupport usage to support other build tools such as bazel
Based on #1674
Signed-off-by: Siarhei Leanavets [email protected]