Engineering: Tune the project settings #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
Makes sense to me. In some cases all the warnings make it near impossible to navigate the file in any editor that shows reference values on the left/right vertical ruler (because they're filled with warnings).
Some overall warnings results from this change :
jdt.ls.core 5655 -> 916
jdt.ls.test 517 -> 149
jdt.ls.syntaxserver 20 -> 6
The .git exclusion shouldn't affect Eclipse is I'm sure instances containing EGit already know to ignore that folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening the eclipse.jdt.ls project in VS Code, it reports 6k+ warnings, most of which are about discouraged access. I tend to suppress discouraged access rules to reduce noise.