Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a preference to control the severity of not covered maven plugin execution #1770

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

testforstephen
Copy link
Contributor

If the client does not define this preference, the server will use the default value of "ignore". This ensures that existing clients are not broken.

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Setting it to "warning" and testing against something like spring-petclinic (with m2e instruction removed) emits the necessary warning.

@testforstephen testforstephen added this to the MId June 2021 milestone Jun 18, 2021
@testforstephen testforstephen merged commit 8c52569 into eclipse-jdtls:master Jun 18, 2021
@testforstephen testforstephen deleted the jinbo_severity branch June 18, 2021 02:09
@testforstephen
Copy link
Contributor Author

Need approve the client side PR as well. redhat-developer/vscode-java#1949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants