Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new preference to disable/enable signature description #2051

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Apr 12, 2022

requires: redhat-developer/vscode-java#2404

  • 'java.signatureHelp.description.enabled' is added to control whether
    the description should be displayed in signature help.

Signed-off-by: sheche [email protected]

@jdneo
Copy link
Contributor Author

jdneo commented Apr 12, 2022

This can be postponed to the End April milestone.

- 'java.signatureHelp.description.enabled' is added to control whether
  the description should be displayed in signature help.

Signed-off-by: sheche <[email protected]>
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change works well for me. I just had a question (above) about default that is probably more applicable to clients that may not support the property.

@rgrunber
Copy link
Contributor

test this please.

(looks like just a random failure)

@rgrunber rgrunber merged commit 22eeba3 into eclipse-jdtls:master Apr 20, 2022
@rgrunber rgrunber added this to the Early May 2022 milestone Apr 20, 2022
@jdneo jdneo deleted the cs/signature-description branch April 21, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants