Support Gradle invalid type code error check #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shi Chen <[email protected]>
|
test this please |
|
|
||
| public static final GradleDistribution DEFAULT_DISTRIBUTION = GradleDistribution.forVersion(GradleVersion.current().getVersion()); | ||
|
|
||
| public static final String IMPORTING_GRADLE_PROJECTS = "Importing Gradle project(s)"; | ||
|
|
||
| public static final String COMPATIBILITY_MARKER_ID = IConstants.PLUGIN_ID + ".gradlecompatibilityerrormarker"; | ||
| public static final String GRADLE_UPGRADE_WRAPPER_MARKER_ID = IConstants.PLUGIN_ID + ".gradleupgradewrappermarker"; | ||
|
|
||
| public static final String GRADLE_INVALID_TYPE_CODE_MESSAGE = "Exact exceptions are not shown due to an outdated Gradle version, please consider to update your Gradle version."; |
There was a problem hiding this comment.
I'd explicitly tell user what Gradle version is required.
For example, change the message to "Exact exceptions are not shown due to a lower Gradle version, please consider to update your Gradle version to 7.2 and above."
| @@ -539,4 +599,16 @@ public GradleCompatibilityInfo(String projectPath, String message, String highes | |||
| this.recommendedGradleVersion = recommendedGradleVersion; | |||
| } | |||
| } | |||
|
|
|||
| private class UpgradeGradleWrapperInfo implements Serializable { | |||
There was a problem hiding this comment.
what's purpose to implements Serializable?
There was a problem hiding this comment.
The UpgradeGradleWrapperInfo objects will be passed to the client side. But it seems other classes like AccessorField didn't implement Serializable and they work well. Seems redundant under LSP?
There was a problem hiding this comment.
lsp4j is using Gson library to serialize a class to json, no need of Serializable interface.
Signed-off-by: Shi Chen <[email protected]>
Signed-off-by: Shi Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to redhat-developer/vscode-java#2442, more details can be found in that PR.
Signed-off-by: Shi Chen [email protected]