Always interpret the full workspace symbol query as a package name. #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
commented
Jul 22, 2022
...e.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/WorkspaceSymbolHandlerTest.java
Outdated
Show resolved
Hide resolved
gayanper
reviewed
Jul 23, 2022
...clipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/WorkspaceSymbolHandler.java
Show resolved
Hide resolved
jdneo
reviewed
Jul 26, 2022
...clipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/WorkspaceSymbolHandler.java
Show resolved
Hide resolved
rgrunber
force-pushed
the
search-all-types
branch
2 times, most recently
from
e220ed6
to
24e7f6a
Compare
|
Before merging, I'll try to compare the performance of this feature on queries that produce roughly the same results before & after this change. That way we can know what overhead is introduced by the additional search. As for using |
|
That sounds good @rgrunber. |
- For a query of 'foo.bar.baz', in addition to searching for all types matching 'baz', whose package matches 'foo.bar', we should also search for all types whose package matches 'foo.bar.baz' - Refactor custom TypeNameMatchRequestor & MethodNameMatchRequestor - Add testcase Signed-off-by: Roland Grunberg <[email protected]>
rgrunber
force-pushed
the
search-all-types
branch
from
24e7f6a
to
4a6a4c2
Compare
|
test this please. |
|
test this please. |
1 similar comment
|
test this please. |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matching 'baz', whose package matches 'foo.bar', we should also search
for all types whose package matches 'foo.bar.baz'
Signed-off-by: Roland Grunberg [email protected]
This was discussed in redhat-developer/vscode-java#2538 (comment)
CC : @gayanper