Search more folders to infer source roots for invisible projects #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/InvisibleProjectImporter.java
Show resolved
Hide resolved
jdneo
commented
Jul 28, 2022
...ipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/InvisibleProjectImporter.java
Show resolved
Hide resolved
rgrunber
reviewed
Aug 4, 2022
...ipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/InvisibleProjectImporter.java
Show resolved
Hide resolved
...ipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/InvisibleProjectImporter.java
Show resolved
Hide resolved
...ipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/InvisibleProjectImporter.java
Outdated
Show resolved
Hide resolved
...ipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/InvisibleProjectImporter.java
Show resolved
Hide resolved
- based on the source root inferred from the trigger file do more search. - if the source root is linked folder, search all direct child folders. - otherwise, search all the sibling folders. Signed-off-by: sheche <[email protected]>
Signed-off-by: sheche <[email protected]>
Signed-off-by: sheche <[email protected]>
Signed-off-by: sheche <[email protected]>
Signed-off-by: Sheng Chen <[email protected]>
jdneo
force-pushed
the
cs/classpath-infer-1
branch
from
3720f3d
to
2fed268
Compare
rgrunber
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another enhancement for inferring the source roots of the invisible projects.
This pre-inference behavior plus the lazy inference, should improve the getting start experience for the unmanaged folders.
Signed-off-by: sheche [email protected]